Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HikariCP to 4.0.1 #10660

Conversation

scala-steward
Copy link
Contributor

Updates com.zaxxer:HikariCP from 3.4.5 to 4.0.1.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.zaxxer", artifactId = "HikariCP" } ]

labels: library-update, semver-major

@mkurz
Copy link
Member

mkurz commented Jan 28, 2021

Seems like there is a problem caused by brettwooldridge/HikariCP#1669 which introduces slf4j 2.0.0-alpha1 dependencies when using Java 11.

[info] EvolutionsReaderSpec
[info] EnvironmentEvolutionsReader should
[error]   ! read evolution files from classpath (204 ms)
[error]    java.lang.ClassCastException: class org.slf4j.helpers.NOPLogger cannot be cast to class ch.qos.logback.classic.Logger (org.slf4j.helpers.NOPLogger and ch.qos.logback.classic.Logger are in unnamed module of loader 'app') (LogbackCapturingAppender.scala:19)
[error] play.api.db.evolutions.LogbackCapturingAppender.<init>(LogbackCapturingAppender.scala:19)
[error] play.api.db.evolutions.LogbackCapturingAppender$.attachForLogger(LogbackCapturingAppender.scala:62)
[error] play.api.db.evolutions.LogbackCapturingAppender$.attachForLogger(LogbackCapturingAppender.scala:56)
[error] play.api.db.evolutions.EvolutionsReaderSpec.$anonfun$new$3(EvolutionsReaderSpec.scala:38)
[error] play.api.db.evolutions.EvolutionsReaderSpec.withLogbackCapturingAppender(EvolutionsReaderSpec.scala:86)
[error] play.api.db.evolutions.EvolutionsReaderSpec.$anonfun$new$2(EvolutionsReaderSpec.scala:37)

@scala-steward
Copy link
Contributor Author

Superseded by #10696.

@scala-steward scala-steward deleted the update/HikariCP-4.0.1 branch February 13, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants