Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect JavaEbean to GitHub #327

Merged

Conversation

ignasi35
Copy link
Member

After playframework/omnidoc#61, going to https://www.playframework.com/documentation/2.7.x/JavaEbean causes a 404.

With this new redirect, both

  1. https://www.playframework.com/documentation/2.7.x/JavaEbean
  2. https://www.playframework.com/documentation/2.8.0-M1/JavaEbean

will return a redirect (see #325) while any GET to a version that has the JavaEbean will be able to render that page.

We still need to see if keeping JavaEbean on the ToC https://www.playframework.com/documentation/2.7.x/JavaHome is what we want, though. But that discussion will/should be addressed on a separate PR.

Related to #325

@ignasi35 ignasi35 self-assigned this Sep 12, 2019
@mergify mergify bot merged commit a71cc82 into playframework:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants