Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@deprecated annotation needs to be constant #641

Merged
merged 1 commit into from Jan 5, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jan 5, 2022

Otherwise scaladoc will complain in Scala 2.13.6
See scala/scala#9336

Happened to me when I wanted to bump to Scala 2.13.7 in omnidoc:
playframework/omnidoc#186

[error] /home/travis/build/playframework/omnidoc/target/scala-2.13/omnidoc/sources/com.typesafe.play-play-slick_2.13-5.0.0/play/api/db/slick/DatabaseConfigProvider.scala:95:100: annotation argument needs to be a constant; found: scala.Predef.augmentString("Use DatabaseConfigProvider#get[P] or SlickApi#dbConfig[P](\"default\") on injected instances").stripMargin
[error]     "Use DatabaseConfigProvider#get[P] or SlickApi#dbConfig[P](\"default\") on injected instances".stripMargin,
[error]                                                                                                    ^
[warn] one warning found
[error] one error found
[error] (Omnidoc / scaladoc) Scaladoc generation failed

https://app.travis-ci.com/github/playframework/omnidoc/jobs/554426274#L1281

Otherwise scaladoc will complain in Scala 2.13.6
See scala/scala#9336
@mkurz
Copy link
Member Author

mkurz commented Jan 5, 2022

@Mergifyio backport 5.0.x

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2022

backport 5.0.x

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify mergify bot merged commit eb1043d into playframework:master Jan 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2022

backport 5.0.x

✅ Backports have been created

@mkurz mkurz deleted the constant_annotation branch January 5, 2022 21:26
mergify bot added a commit that referenced this pull request Jan 5, 2022
@xuwei-k
Copy link
Contributor

xuwei-k commented Jan 23, 2022

@mkurz
Copy link
Member Author

mkurz commented Jan 23, 2022

@xuwei-k Sorry, I didn't see you pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants