Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cmd.yml #757

Merged
merged 5 commits into from May 6, 2022
Merged

Switch to cmd.yml #757

merged 5 commits into from May 6, 2022

Conversation

@mkurz mkurz marked this pull request as ready for review May 3, 2022 21:58
@mkurz mkurz marked this pull request as draft May 3, 2022 21:59
@mkurz mkurz closed this May 3, 2022
@mkurz mkurz reopened this May 3, 2022
@mkurz
Copy link
Member Author

mkurz commented May 3, 2022

I have no idea why GitHub action test workflow isn't running for this PR...

@BillyAutrey
Copy link
Member

I have no idea why GitHub action test workflow isn't running for this PR...

Found the error here - https://github.com/playframework/play-json/actions/runs/2266633506/workflow#L34

If you click on Checks for a PR that doesn't run checks, you can see which step has an error on the left. It shows up as a text box with an exclamation point.

From there, it says:

Invalid workflow file: .github/workflows/build-test.yml#L34
invalid value workflow reference: workflow file should have either a '.yml' or '.yaml' file extension

Clicking in on that error takes me to the first link. Seems it doesn't like the format of that command file, because it thinks playframework/.github/.github/workflows/contact@playframework.com isn't a proper yaml.

@BillyAutrey
Copy link
Member

Changed the file, and now it works. :)

@mkurz
Copy link
Member Author

mkurz commented May 4, 2022

If you click on Checks for a PR that doesn't run checks, you can see which step has an error on the left. It shows up as a text box with an exclamation point.

Actually I do know that and used those error messages a lot when I worked on all that GitHub actions stuff. However yesterday it was different; I had the feeling the check actually did not even run, like the workflow file did not get parsed at all (yet). Like there was not even the check showing up. Maybe there was no free vm from GitHub to pick the workflow or whatever. Anyway, thanks!

@mkurz mkurz marked this pull request as ready for review May 6, 2022 09:50
@mergify mergify bot merged commit b446f4e into playframework:main May 6, 2022
@mkurz mkurz deleted the cmd.yml branch May 6, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants