Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve universal CMD task #20

Merged
merged 1 commit into from May 5, 2022
Merged

Improve universal CMD task #20

merged 1 commit into from May 5, 2022

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented May 4, 2022

  • java/scala parameters of CMD as simple comma separated string
  • Docs

@ihostage ihostage requested a review from mkurz May 4, 2022 14:24
@mkurz
Copy link
Member

mkurz commented May 4, 2022

Great! I will give it a try in the open pull requests.

@ihostage ihostage mentioned this pull request May 4, 2022
Merged
@ihostage
Copy link
Member Author

ihostage commented May 5, 2022

I added custom ref parameter for playframework/playframework#11262

mkurz
mkurz approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mkurz
Copy link
Member

mkurz commented May 5, 2022 •
edited

I will squash before...

@ihostage @mkurz
* java/scala parameters of CMD as simple comma separated string
83edfb2 
* Docs
* Add `ref` parameter to any workflows for checkout to special branch, tag or SHA
@mkurz mkurz merged commit 2dd5218 into dynamic_matrix May 5, 2022
@mkurz mkurz deleted the cmd-ihostage branch May 5, 2022 20:45
@mkurz mkurz mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ihostage @mkurz