Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printer: fix clearing the progress/spinner output #312

Merged
merged 1 commit into from Jun 21, 2021
Merged

printer: fix clearing the progress/spinner output #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/printer/printer.go
View file
Open in desktop
Expand Up @@ -133,6 +133,11 @@ func (p *Printer) PrintProgress(message string) func() {
s.Start()
return func() {
s.Stop()

// NOTE(fatih) the spinner library doesn't clear the line properly,
// hence remove it ourselves. This line should be removed once it's
// fixed in upstream. https://github.com/briandowns/spinner/pull/117
fmt.Fprint(p.out(), "\r\033[2K")
}
}

Expand Down