add RedisCacheHandler #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that. Looks like you will have to add the redis package in https://github.com/plamere/spotipy/blob/master/setup.py Please also update the changelog |
Findus23
reviewed
Nov 25, 2021
| def get_cached_token(self): | ||
| token_info = None | ||
| try: | ||
| token_info = json.loads(self.redis.get('token_info')) |
There was a problem hiding this comment.
Won't self.redis.get('token_info') be None if the value hasn't yet been stored in Redis and then json.loads(None) throw an exception?
There was a problem hiding this comment.
@Findus23
You're right. I'm sorry for that. I'll fix it.
IdmFoundInHim
pushed a commit
to IdmFoundInHim/spotipy
that referenced
this pull request
Dec 23, 2021
* add RedisCacheHandler * add the explanation for customized chache handlers * update the dependency and chengelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used redis for token caching in my project, so I contribute this.
This may be useful when using multiple servers.
I'm not sure if I should include redis-py library to dependency of this project because redis library is not directly necessary for main functions of spotipy and only necessary for
RedisCacheHandler.May I have your help?