Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer /usr/bin/pgrep to other pgrep if available #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prefer /usr/bin/pgrep to other pgrep if available #33

wants to merge 1 commit into from
+19 −1

Conversation

hyangah
Copy link

@hyangah hyangah commented Jun 17, 2020

Use the default pgrep, available since os x mountain lion.
proctools' pgrep does not implement -P correctly, returns
unrelated processes, breaks tree-kill's assumption, and may
cause a large number of pgrep processes.

Reported in #17 (comment)

Update golang/vscode-go#90 (comment)

@hyangah
prefer /usr/bin/pgrep to other pgrep if available
05397b4 
Use the default pgrep, available since os x mountain lion.
proctools' pgrep does not implement `-P` correctly, returns
unrelated processes, breaks tree-kill's assumption, and may
cause a large number of pgrep processes.

Reported in pkrumins#17 (comment)

Update golang/vscode-go#90 (comment)
@hyangah
Copy link
Author

hyangah commented Jun 26, 2020

Is there any chance this gets reviewed? Thanks!

@hyangah
Copy link
Author

hyangah commented Nov 6, 2020

@TomasFlow Thanks for the approval. What's the next step? Will the new version be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micalevisk micalevisk micalevisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyangah @micalevisk