Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation warnings #10

Closed
wants to merge 2 commits into from
Closed

Conversation

ferki
Copy link

@ferki ferki commented Jan 25, 2023

This is a proposed PR to fix #9 by updating the bundled version of actions/setup-python#v2.

The changes were generated by running the following commands:

  • npm install
  • npm run prepare

I am not sure if that's the correct way to do it, or whether it's covering the full scope of changes required or not.

Please review, and provide feedback about whether I'm on the right track or not.

ps.: There are also

3 vulnerabilities (1 moderate, 2 high)

reported by npm install, so it might be a good idea to update more dependencies.

I will try to look into the recommended npm audit and npm audit fix commands, and may push some follow-up commits.

@ferki
Copy link
Author

ferki commented Jan 25, 2023

I've pushed a second commit which is the result of running npm audit fix. Let me know if anything else needs updated on top of these changes or even instead of them, and I'm happy update the PR accordingly.

Perhaps some dependencies in package.json?

@arthurzam
Copy link
Member

We have moved to new approach, to use dockerfile variant. So, thank you for the work, but we have better solution for now.

@arthurzam arthurzam closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning annotations about set-output on each run
2 participants