Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zos/s390x #582

Merged
merged 4 commits into from Apr 6, 2024
+203 −258
Merged

Add support for zos/s390x #582

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b553cc
Add support for zos/s390x
dustin-ward Apr 4, 2024
96b29c5
address review set 1
dustin-ward Apr 5, 2024
8411183
address review set 2
dustin-ward Apr 5, 2024
3588ee8
fix godoc comment
dustin-ward Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions stat.go
View file
Open in desktop
Expand Up @@ -85,9 +85,5 @@ const (
s_ISVTX = uint32(sshfx.ModeSticky)
)

// Legacy export:
//
// Go defines S_IFMT on windows, plan9 and js/wasm as 0x1f000 instead of
// 0xf000. None of the the other S_IFxyz values include the "1" (in 0x1f000)
// which prevents them from matching the bitmask.
// S_IFMT is a legacy export. `sshfx.ModeType` should be used instead
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the sshfx package is internal and so no one else can import it. So, the given alternative isn’t useful.

I would say that the local OS might use a different value from what we need to use internally, and there is no reason anyone should need this specific internal value.

We can also merge, and then I can adjust it after.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. That makes more sense. Better to have you leave the comment anyways. Thanks again

const S_IFMT = uint32(sshfx.ModeType)