Memfile stuff

request-attrs.go

@@ -44,6 +44,37 @@ func newFileAttrFlags(flags uint32) FileAttrFlags {
 	}
 }
 
+func (r *Request) SetAttributes(flags FileAttrFlags, attrs FileStat) error {
+	r.Method = "Setstat"
+
+	buf := []byte{}
+
+	r.Flags = 0
+
+	if flags.Size {
+		r.Flags |= sshFileXferAttrSize
+		buf = marshalUint64(buf, attrs.Size)
+	}
+	if flags.UidGid {
+		r.Flags |= sshFileXferAttrUIDGID
+		buf = marshalUint32(buf, attrs.UID)
+		buf = marshalUint32(buf, attrs.GID)
+	}
+	if flags.Permissions {
+		r.Flags |= sshFileXferAttrPermissions
+		buf = marshalUint32(buf, attrs.Mode)
+	}
+
+	if flags.Acmodtime {
+		r.Flags |= sshFileXferAttrACmodTime
+		buf = marshalUint32(buf, attrs.Atime)
+		buf = marshalUint32(buf, attrs.Mtime)
+	}
+
+	r.Attrs = buf
+	return nil
+}
+
 // AttrFlags returns a FileAttrFlags boolean struct based on the
 // bitmap/uint32 file attribute flags from the SFTP packaet.
 func (r *Request) AttrFlags() FileAttrFlags {

request-example.go

@@ -72,7 +72,7 @@ func (fs *root) putfile(pathname string, file *memFile) error {
 		return os.ErrInvalid
 	}
 
-	if _, err := fs.lfetch(pathname); err != os.ErrNotExist {
+	if _, err := fs.lfetch(pathname); !errors.Is(err, os.ErrNotExist) {
 		return os.ErrExist
 	}
 
@@ -110,6 +110,7 @@ func (fs *root) openfile(pathname string, flags uint32) (*memFile, error) {
 
 		file := &memFile{
 			modtime: time.Now(),
+			mode:    0644,
 		}
 
 		if err := fs.putfile(pathname, file); err != nil {
@@ -140,6 +141,25 @@ func (fs *root) openfile(pathname string, flags uint32) (*memFile, error) {
 	return file, nil
 }
 
+func (fs *root) SetStat(r *Request, flags *FileAttrFlags, attrs *FileStat) error {
+	file, err := fs.openfile(r.Filepath, sshFxfWrite)
+	if err != nil {
+		return err
+	}
+
+	if flags.Permissions {
+		file.mode = attrs.Mode
+	}
+	// We only have mtime, not atime.
+	if flags.Acmodtime {
+		file.modtime = time.Unix(int64(attrs.Mtime), 0)
+	}
+	if flags.Size {
+		return file.Truncate(int64(attrs.Size))
+	}
+	return nil
+}
+
 func (fs *root) Filecmd(r *Request) error {
 	if fs.mockErr != nil {
 		return fs.mockErr
@@ -151,16 +171,8 @@ func (fs *root) Filecmd(r *Request) error {
 
 	switch r.Method {
 	case "Setstat":
-		file, err := fs.openfile(r.Filepath, sshFxfWrite)
-		if err != nil {
-			return err
-		}
-
-		if r.AttrFlags().Size {
-			return file.Truncate(int64(r.Attributes().Size))
-		}
-
-		return nil
+		flags := r.AttrFlags()
+		return fs.SetStat(r, &flags, r.Attributes())
 
 	case "Rename":
 		// SFTP-v2: "It is an error if there already exists a file with the name specified by newpath."
@@ -209,7 +221,7 @@ func (fs *root) rename(oldpath, newpath string) error {
 	}
 
 	target, err := fs.lfetch(newpath)
-	if err != os.ErrNotExist {
+	if !errors.Is(err, os.ErrNotExist) {
 		if target == file {
 			// IEEE 1003.1: if oldpath and newpath are the same directory entry,
 			// then return no error, and perform no further action.
@@ -507,7 +519,7 @@ func (fs *root) exists(path string) bool {
 
 	_, err = fs.lfetch(path)
 
-	return err != os.ErrNotExist
+	return !errors.Is(err, os.ErrNotExist)
 }
 
 func (fs *root) fetch(pathname string) (*memFile, error) {
@@ -544,6 +556,7 @@ type memFile struct {
 	modtime time.Time
 	symlink string
 	isdir   bool
+	mode    uint32
 
 	mu      sync.RWMutex
 	content []byte
@@ -569,7 +582,7 @@ func (f *memFile) Mode() os.FileMode {
 	if f.symlink != "" {
 		return os.FileMode(0777) | os.ModeSymlink
 	}
-	return os.FileMode(0644)
+	return os.FileMode(f.mode)
 }
 func (f *memFile) ModTime() time.Time { return f.modtime }
 func (f *memFile) IsDir() bool        { return f.isdir }

request-interfaces.go

@@ -155,3 +155,9 @@ type ListerAt interface {
 type TransferError interface {
 	TransferError(err error)
 }
+
+// FileStatSetter is an optional interface that a writerAt could implement in order to allow direct setting of stats.
+// This is primarily used for the inmemhandler backend.
+type FileStatSetter interface {
+	SetStat(r *Request, flags *FileAttrFlags, attrs *FileStat) error
+}