fix(core): Make set/delete warning condition for undefined, null and

primitive values more precise. Corrects vuejs#7452
pkaminski · Mar 13, 2018 · 876d7f9 · 876d7f9
1 parent 731b498
commit 876d7f9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/core/observer/index.js b/src/core/observer/index.js
@@ -10,6 +10,8 @@ import {
   hasProto,
   isObject,
   isPlainObject,
+  isPrimitive,
+  isUndef,
   isValidArrayIndex,
   isServerRendering
 } from '../util/index'
@@ -195,10 +197,9 @@ export function defineReactive (
  */
 export function set (target: Array<any> | Object, key: any, val: any): any {
   if (process.env.NODE_ENV !== 'production' &&
-    !Array.isArray(target) &&
-    !isObject(target)
+    (isUndef(target) || isPrimitive(target))
   ) {
-    warn(`Cannot set reactive property on non-object/array value: ${target}`)
+    warn(`Cannot set reactive property on undefined, null, or primitive value: ${(target: any)}`)
   }
   if (Array.isArray(target) && isValidArrayIndex(key)) {
     target.length = Math.max(target.length, key)
@@ -231,10 +232,9 @@ export function set (target: Array<any> | Object, key: any, val: any): any {
  */
 export function del (target: Array<any> | Object, key: any) {
   if (process.env.NODE_ENV !== 'production' &&
-    !Array.isArray(target) &&
-    !isObject(target)
+    (isUndef(target) || isPrimitive(target))
   ) {
-    warn(`Cannot delete reactive property on non-object/array value: ${target}`)
+    warn(`Cannot delete reactive property on undefined, null, or primitive value: ${(target: any)}`)
   }
   if (Array.isArray(target) && isValidArrayIndex(key)) {
     target.splice(key, 1)

diff --git a/test/unit/modules/observer/observer.spec.js b/test/unit/modules/observer/observer.spec.js
@@ -360,12 +360,12 @@ describe('Observer', () => {
     try {
       setProp(null, 'foo', 1)
     } catch (e) {}
-    expect(`Cannot set reactive property on non-object/array value`).toHaveBeenWarned()
+    expect(`Cannot set reactive property on undefined, null, or primitive value`).toHaveBeenWarned()
 
     try {
       delProp(null, 'foo')
     } catch (e) {}
-    expect(`Cannot delete reactive property on non-object/array value`).toHaveBeenWarned()
+    expect(`Cannot delete reactive property on undefined, null, or primitive value`).toHaveBeenWarned()
   })
 
   it('should lazy invoke existing getters', () => {