Move image processing to ImageMagick (Wand). #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is still much more work to do on this PR. We need to add a JS library of some form to allow you to start playing the animated GIFs as I don't want them to be playing on the screen constantly. This is related to issue #241.
|
@mcrmonkey comments? |
I also re-enabled the debugger instead of error pages. I don't know why I left it in during the first commit. This also needs fixing.
Current coverage is 100%@@ master #270 diff @@
====================================
Files 32 32
Lines 1804 1826 +22
Methods 0 0
Messages 0 0
Branches 284 288 +4
====================================
+ Hits 1804 1826 +22
Misses 0 0
Partials 0 0
|
|
not tested it myself but the code appears sane on the surface. thought it would be a bigger rewrite too. |
|
If you could get it up and running and try and break it that would be handy. It's also shrunk the Debian dependencies to 1. I've updated the docs and what not in the README so it can be build and the Dockerfile. |
Now cycle through each image of an animated GIF and re-sizes it adding it to a temporary image. The main image is then swapped for this temporary image.
Animated GIFs will not be loaded unless you press the `GIF` button. jQuery GIF player is being used to switch between the PNG preview and the actual animated GIF. Tests have been tweaked and every where the `process_upload` is. This now returned 2 arguments filename and animated_filename. The templated now also add a `gif` class to an image if it is an animated gif.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still much more work to do on this PR.
We need to add a JS library of some form to allow you to start playing
the animated GIFs as I don't want them to be playing on the screen
constantly.
This is related to issue #241.