-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Lerna for versioning and publishing #9125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine under npm@8.19.3
but doesn't seem to work under npm@9.4.1
.
I tried npm run release
and it seems that npm install --package-lock-only
in release.ts
is not working properly.
With network disabled:
? Release version (currently v7.1.2): Patch (v7.1.3)
npm ERR! code ENOTFOUND
npm ERR! syscall getaddrinfo
npm ERR! errno ENOTFOUND
npm ERR! network request to https://registry.npmjs.org/@pixi%2fparticle-container failed, reason: getaddrinfo ENOTFOUND registry.npmjs.org
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
With network enabled:
? Release version (currently v7.1.2): Patch (v7.1.3)
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @pixi/particle-container@7.1.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
I think you found a npm regression in npm/cli#3964 |
Okay, I'm not sure what's going on in npm@9 and |
One idea I have to circumvent this whole version bumping issue is to use Edit: Okay, I made this change. I think it's much better. |
Need to figure out why Rollup hates the |
Should we also update |
Co-authored-by: Tianlan Zhou <bobby825@126.com>
Co-authored-by: Tianlan Zhou <bobby825@126.com>
Co-authored-by: Tianlan Zhou <bobby825@126.com>
Co-authored-by: Tianlan Zhou <bobby825@126.com>
This PR builds on existing work (removing the use of Lerna within the project and replaced it with workspaces and workspaces-run). The holdouts for remove Lerna completely were version bumping and publishing.
This PR manually recreates the the version bumping mechanism from Lerna. Publish was an easy replacement with workspaces-run. Luckily our version bump strategy is very simple (e.g.,
lerna version --exact --force-publish
). Replicating this was straightforward.Features
Other Changes
scripts/fixPeerVersions.ts
, as it is no longer usednpx --yes npm@7.20.2 i --package-lock-only
workaroundVerifying
npx ts-node scripts/release.ts --no-push
npm ts-node scripts/prepublish.ts