Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDN Install section in READMEs for browser builds #9020

Merged
merged 1 commit into from Jan 5, 2023

Conversation

SuperSodaSea
Copy link
Member

Description of change

Follow up #8827. Users may be confused about how to use browser build version of plugins (#9019), so I add examples for it in package's README.md. This will show up on the https://npmjs.com pages, and it can be helpful for users.

(The CDN URL in /README.md was wrong, caused by the different directory structure between v6 and v7. Now it is fixed.)

Pre-Merge Checklist

  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@SuperSodaSea SuperSodaSea added this to the v7.1.0 milestone Dec 26, 2022
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, thank you!

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Dec 26, 2022
@bigtimebuddy bigtimebuddy merged commit 0ba5ec7 into dev Jan 5, 2023
@bigtimebuddy bigtimebuddy deleted the docs/cdn-install branch January 5, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants