Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: IRenderer.generateTexture should return RenderTexture #8951

Merged
merged 2 commits into from Dec 8, 2022
Merged

Fix: IRenderer.generateTexture should return RenderTexture #8951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b7aa3
Fix: generateTexture should return RenderTexture
SuperSodaSea Dec 8, 2022
7d93bfe
Merge branch 'dev' into fix/generate-texture
SuperSodaSea Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/core/src/IRenderer.ts
View file
Open in desktop
Expand Up @@ -113,10 +113,9 @@ export interface IRendererRenderOptions
*/
export interface IRenderer<VIEW extends ICanvas = ICanvas> extends SystemManager, GlobalMixins.IRenderer
{

resize(width: number, height: number): void;
render(displayObject: IRenderableObject, options?: IRendererRenderOptions): void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that we are having mixed style for member delimiter (f(): T, f(): T, and f(): T; all exist!), I think we definitely need something like @typescript-eslint/member-delimiter-style. However in its document (and in @typescript-eslint/comma-dangle's) it says:

DANGER
We strongly recommend you do not use this rule or any other formatting linter rules. Use a separate dedicated formatter instead. See What About Formatting? for more information.

@bigtimebuddy What do you think?

BTW, what's wrong with the GitHub Actions? Seems that all of them stuck in "Run Unit Tests" :( -> 8952

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, would be nice to be consistent about this, but not the high priority for me atm.

generateTexture(displayObject: IRenderableObject, options?: IGenerateTextureOptions): void
render(displayObject: IRenderableObject, options?: IRendererRenderOptions): void;
generateTexture(displayObject: IRenderableObject, options?: IGenerateTextureOptions): RenderTexture;
destroy(removeView?: boolean): void;
clear(): void;
reset(): void;
Expand Down