Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unused Asset.init options #8903

Merged
merged 1 commit into from Nov 30, 2022
Merged

Cleanup unused Asset.init options #8903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 1 addition & 16 deletions packages/assets/src/Assets.ts
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ import { isSingleItem } from './utils/isSingleItem';

import type { FormatDetectionParser } from './detections';
import type { LoadAsset, LoaderParser } from './loader';
import type { PreferOrder, ResolveAsset, ResolveURLParser, ResolverBundle, ResolverManifest } from './resolver';
import type { ResolveAsset, ResolverBundle, ResolverManifest } from './resolver';

export type ProgressCallback = (progress: number) => void;

Expand Down Expand Up @@ -46,21 +46,6 @@ export interface AssetInitOptions
parsers?: LoaderParser[];
// more...
};
/** resolver specific options */
resolver?: {
/**
* a list of urlParsers, these can read the URL and pick put the various options.
* for example there is a texture URL parser that picks our resolution and file format.
* You can add custom ways to read URLs and extract information here.
*/
urlParsers?: ResolveURLParser[];
/**
* a list of preferOrders that let the resolver know which asset to pick.
* already built-in we have a texture preferOrders that let the resolve know which asset to prefer
* if it has multiple assets to pick from (resolution/formats etc)
*/
preferOrders?: PreferOrder[];
};
}

/**
Expand Down