Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing resolution setter for Renderer and CanvasRenderer #8825

Merged
merged 1 commit into from Nov 7, 2022
Merged

Add missing resolution setter for Renderer and CanvasRenderer #8825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/canvas-renderer/src/CanvasRenderer.ts
View file
Open in desktop
Expand Up @@ -189,7 +189,17 @@ export class CanvasRenderer extends SystemManager<CanvasRenderer> implements IRe
options = Object.assign({}, settings.RENDER_OPTIONS, options);

const systemConfig = {
runners: ['init', 'destroy', 'contextChange', 'reset', 'update', 'postrender', 'prerender', 'resize'],
runners: [
'init',
'destroy',
'contextChange',
'resolutionChange',
'reset',
'update',
'postrender',
'prerender',
'resize'
],
systems: CanvasRenderer.__systems,
priority: [
'textureGenerator',
Expand Down Expand Up @@ -325,6 +335,11 @@ export class CanvasRenderer extends SystemManager<CanvasRenderer> implements IRe
{
return this._view.resolution;
}
set resolution(value: number)
{
this._view.resolution = value;
this.runners.resolutionChange.emit(value);
}

/** Whether CSS dimensions of canvas view should be resized to screen dimensions automatically. */
get autoDensity(): boolean
Expand Down
17 changes: 16 additions & 1 deletion packages/core/src/Renderer.ts
View file
Open in desktop
Expand Up @@ -326,7 +326,17 @@ export class Renderer extends SystemManager<Renderer> implements IRenderer
}, true);

const systemConfig = {
runners: ['init', 'destroy', 'contextChange', 'reset', 'update', 'postrender', 'prerender', 'resize'],
runners: [
'init',
'destroy',
'contextChange',
'resolutionChange',
'reset',
'update',
'postrender',
'prerender',
'resize'
],
systems: Renderer.__systems,
priority: [
'_view',
Expand Down Expand Up @@ -482,6 +492,11 @@ export class Renderer extends SystemManager<Renderer> implements IRenderer
{
return this._view.resolution;
}
set resolution(value: number)
{
this._view.resolution = value;
this.runners.resolutionChange.emit(value);
}

/** Whether CSS dimensions of canvas view should be resized to screen dimensions automatically. */
get autoDensity(): boolean
Expand Down
9 changes: 9 additions & 0 deletions packages/events/src/EventSystem.ts
View file
Open in desktop
Expand Up @@ -130,6 +130,15 @@ export class EventSystem
this.resolution = resolution;
}

/**
* Handle changing resolution.
* @ignore
*/
resolutionChange(resolution: number): void
{
this.resolution = resolution;
}

/** Destroys all event listeners and detaches the renderer. */
destroy(): void
{
Expand Down
15 changes: 15 additions & 0 deletions packages/events/test/EventSystem.tests.ts
View file
Open in desktop
Expand Up @@ -365,4 +365,19 @@ describe('EventSystem', () =>
done();
}, 800);
});

it('should inherit resolution changes', () =>
{
const renderer = createRenderer();

renderer.resolution = 2;

expect(renderer.resolution).toEqual(2);
expect(renderer.events.resolution).toEqual(2);

renderer.resolution = 1;

expect(renderer.resolution).toEqual(1);
expect(renderer.events.resolution).toEqual(1);
});
});