Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Version Bumping Cross-platform, Update Lerna #7929

Merged
merged 7 commits into from Nov 4, 2021
Merged

Make Version Bumping Cross-platform, Update Lerna #7929

merged 7 commits into from Nov 4, 2021

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented Oct 28, 2021 •
edited

Improved workaround for lerna/lerna#2891 by using version lifecycle.

Changed

  • Removes the bash script for publishing, more cross-platform compatible
  • Bumps Lerna to v4
  • Less anti-pattern with Lerna

Unresolved

  • I was unable to get npm install --package-lock-only working in the version script, will try again later, but that would be ideal and allow me to remove the manual package-lock fix. Found that it was an npm bug, reflected this in the CI and engines requirements

@bigtimebuddy bigtimebuddy marked this pull request as ready for review October 29, 2021 19:15
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Nov 2, 2021
@bigtimebuddy bigtimebuddy merged commit eab85e9 into dev Nov 4, 2021
@bigtimebuddy bigtimebuddy deleted the fix-publishing branch November 4, 2021 16:30
@domis86 domis86 mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShukantPal ShukantPal ShukantPal approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigtimebuddy @ShukantPal @Zyie