New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add automated published branch releases for dev & main #10520
Conversation
My review is in progress 📖 - I will have feedback for you in a few minutes! |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a194cab:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed your code and found 1 potential issue. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
@danielbarion We (@Zyie @GoodBoyDigital and I) had a chance to review this change this morning. Overall we love the general idea and thank you for proposing it! Super useful feature to opt-in to bleeding-edge unreleased changes. @Zyie pointed out that our codesandbox integration offers some of this (at least testing purposes) for PRs and there is also a mechanism to download a build (I think) using that tool. That said, we still think there's something here and we have some feedback. If you don't have time to work on these, just let us know someone on the team will likely pick it up.
What do you think? |
Hey @bigtimebuddy & team, it does make sense! the initial implementation is the same as we have on ReactTooltip that matches our needs. Thank you so much for reviewing this suggestion and for the detailed feedback, I really appreciate that! I would like to focus on those changes so the Pixi team can concentrate on other stuff, I have a test repository where I developed this workflow initially to not release the test versions directly on the ReactTooltip project, I'll use it to apply the needs mentioned on your feedback. I'll keep you guys in the loop. Thanks! Edit: What should be the name of the workflow? |
Maybe, |
4ead2dc
to
47bf56d
Compare
https://www.npmjs.com/package/auto-beta-release?activeTab=versions The code was updated, please let me know if something else is needed, I didn't update the PR description because of our comments, but please let me know your thoughts about it and about the changes |
Co-authored-by: Matt Karl <matt@mattkarl.com>
@danielbarion I did a quick experiment here that seemed to work for me: Added two args to
|
Co-authored-by: Matt Karl <matt@mattkarl.com>
@bigtimebuddy hmm, interesting, maybe it's the action I was using? I saw the project is using v3 and I was using v4 initially ( Thanks for letting me know |
Sorry, I asked review again but I forgot to apply the change, 1 second. |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert the package.json and package-lock and I think we are good to go!
@bigtimebuddy NPM sorted the package by itself, should I remove it too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, are we even building before the publish?
@bigtimebuddy @danielbarion is everything all settled with this PR now? |
yes @Zyie |
Yeah, I'm good on this. I think we should merge this into dev and just validate that everyone is working as expected. |
Ok this seems to be working! https://www.npmjs.com/package/pixi.js/v/8.1.5-dev.141f7e0?activeTab=versions Thank you @danielbarion for adding this |
@Zyie do you want me to do the PR to main? |
no it's ok, this will get merged into main when i do the next release |
Description of change
I recently implemented a beta-release workflow on the react-tooltip project, maybe it can be interesting for Pixi.js project too.
On ReactTooltip project, we always try to release a beta version on some PR before merging it to let the owner of the issue test and confirm if the issue was solved, this also unblocks projects that are waiting for some fix before we release an official version with the fix.
With the beta release workflow, all commits into the PR will trigger the beta release.
pixi.js@{__VERSION__}-beta.{__PR_NUMBER__}.rc.{__BETA_VERSION__}
->pixi.js@v0.0.11-beta.1.rc.1
__VERSION__
- current package.json version on this PR__PR_NUMBER__
- current PR number__BETA_VERSION__
- latest beta version releasedhttps://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs
Examples
ReactTooltip/react-tooltip#1179 (comment)
https://github.com/ReactTooltip/react-tooltip/actions/runs/9007001657/job/24745795089?pr=1179
The previous beta version is
null
because that's the first beta release for this PR number.https://www.npmjs.com/package/react-tooltip?activeTab=versions
Note: ReactTooltip master branch has the CJS code (same as this PR), on V6 branch we have it as ESM version of the code.