Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export shapeBuildCommandMap to allow custom shape primitives #10508

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Export shapeBuildCommandMap to allow custom shape primitives #10508

wants to merge 3 commits into from
+28 −4

Conversation

ShukantPal
Copy link
Member

This is affecting the upgrade of @pixi-essentials/svg to v8 (specifically, for rendering <path> elements). :)

@ShukantPal
Export shapeBuildCommandMap to allow custom shape primitives
7fcb3a3 
This is affecting the upgrade of @pixi-essentials/svg to v8. :)
@ShukantPal ShukantPal added the 👀 Needs Review PR needs to be reviewed by someone on the core team. label May 5, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 5, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69dce19:

Sandbox Source
pixi.js-sandbox Configuration

bigtimebuddy
bigtimebuddy reviewed May 5, 2024
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you thinks this could be another extension type? I like using extensions for any potential extensibility (renderer systems, asset parsers, application plugins), why not shapes?

src/scene/graphics/shared/utils/buildContextBatches.ts Outdated Show resolved Hide resolved
GoodBoyDigital
GoodBoyDigital approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@GoodBoyDigital GoodBoyDigital added ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t and removed 👀 Needs Review PR needs to be reviewed by someone on the core team. labels May 7, 2024
@Zyie Zyie added the v8 label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy left review comments

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShukantPal @bigtimebuddy @GoodBoyDigital @Zyie