Fix: handling of getRenderTarget when passing in a canvas #10507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 153578d:
|
ShukantPal
added
the
👀 Needs Review
|
nice catch @ShukantPal ! would you mind adding a unit test pls? |
GoodBoyDigital
approved these changes
May 7, 2024
|
@GoodBoyDigital Done! |
bigtimebuddy
added
✅ Ready To Merge
Zyie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Right now,
getRenderTarget(canvas)returns null because of how the canvas is converted into aTextureSource.In the code,
getCanvasTexturereturns a texture, but the 2 if conditions ingetRenderTargetonly handle render targets and texture sources.This change updates it so that a canvas is converted into a canvas source, not a texture.