Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: incorrect cache warning check #10430

Open
wants to merge 1 commit into
base: v7.x
Choose a base branch
from
Open

Fix: incorrect cache warning check #10430

wants to merge 1 commit into from

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Apr 9, 2024

We were checking the wrong value when testing if an asset is different, resulting in a bunch of warnings for things like spritesheets

@Zyie Zyie requested a review from bigtimebuddy April 9, 2024 19:35
Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0421fb:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@Zyie Zyie added the v7 label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants