Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: IRenderer.generateTexture should return RenderTexture #8951

Merged
merged 2 commits into from Dec 8, 2022
Merged

Fix: IRenderer.generateTexture should return RenderTexture #8951

merged 2 commits into from Dec 8, 2022

Conversation

SuperSodaSea
Copy link
Member

Description of change

IRenderer.generateTexture should return RenderTexture instead of void.

Fixes #8947.

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@SuperSodaSea SuperSodaSea added this to the v7.1.0 milestone Dec 8, 2022
SuperSodaSea
SuperSodaSea commented Dec 8, 2022
View reviewed changes
packages/core/src/IRenderer.ts
resize(width: number, height: number): void;
render(displayObject: IRenderableObject, options?: IRendererRenderOptions): void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that we are having mixed style for member delimiter (f(): T, f(): T, and f(): T; all exist!), I think we definitely need something like @typescript-eslint/member-delimiter-style. However in its document (and in @typescript-eslint/comma-dangle's) it says:

DANGER
We strongly recommend you do not use this rule or any other formatting linter rules. Use a separate dedicated formatter instead. See What About Formatting? for more information.

@bigtimebuddy What do you think?

BTW, what's wrong with the GitHub Actions? Seems that all of them stuck in "Run Unit Tests" :( -> 8952

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, would be nice to be consistent about this, but not the high priority for me atm.

bigtimebuddy
bigtimebuddy approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Dec 8, 2022
@bigtimebuddy bigtimebuddy merged commit 1325282 into dev Dec 8, 2022
@bigtimebuddy bigtimebuddy deleted the fix/generate-texture branch December 8, 2022 14:34
@robfuscator
Copy link

Thank you, your work is much appreciated!

bigtimebuddy pushed a commit that referenced this pull request Dec 12, 2022
@SuperSodaSea @bigtimebuddy
Fix: generateTexture types should return RenderTexture (#8951)
81a9ef5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

IRenderer.generateTexture() returns void according to type system
3 participants
@SuperSodaSea @robfuscator @bigtimebuddy