Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unused Asset.init options #8903

Merged
merged 1 commit into from Nov 30, 2022
Merged

Cleanup unused Asset.init options #8903

merged 1 commit into from Nov 30, 2022

Conversation

bigtimebuddy
Copy link
Member

The resolver options in the AssetInitOptions never was used.

The preferred way to change these things is:

  • Use extensions.add (for options.resolver.urlParsers)
  • Use Assets.resolver.prefer (for options.resolver.preferOrders)

@bigtimebuddy bigtimebuddy added this to the v7.1.0 milestone Nov 29, 2022
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Nov 30, 2022
@bigtimebuddy bigtimebuddy merged commit eacfa54 into dev Nov 30, 2022
@bigtimebuddy bigtimebuddy deleted the chore/assets-unused-options branch November 30, 2022 11:47
bigtimebuddy added a commit that referenced this pull request Dec 12, 2022
@bigtimebuddy
Chore: Remove unused Assets.init options (#8903)
bc0a0f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bigtimebuddy @Zyie