Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix culling not working with projection transforms #8844

Merged
merged 2 commits into from Nov 15, 2022
Merged

Fix culling not working with projection transforms #8844

merged 2 commits into from Nov 15, 2022

Conversation

dev7355608
Copy link
Collaborator

Culling didn't include the projection transform in its calculation.

Test: Generate texture from red square graphics with culling enabled.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Nov 14, 2022
@bigtimebuddy bigtimebuddy added this to the v7.1.0 milestone Nov 14, 2022
@bigtimebuddy bigtimebuddy merged commit 9555a58 into dev Nov 15, 2022
@bigtimebuddy bigtimebuddy deleted the fix/cullableProjTransform branch November 15, 2022 16:08
@bigtimebuddy
Copy link
Member

Thanks @dev7355608

bigtimebuddy pushed a commit that referenced this pull request Dec 12, 2022
@dev7355608 @bigtimebuddy
Fix culling not working with projection transforms (#8844)
2e90711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dev7355608 @bigtimebuddy