Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resolution setter for Renderer and CanvasRenderer #8825

Merged
merged 1 commit into from Nov 7, 2022

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented Nov 6, 2022

Closes #8792
Closes #8804

There are uses cases like automatically adjusting the resolution based on the browser zoom. This automatically adjusts the Event's resolution as well.

🎁 Added

  • Adds setter for Renderer and CanvasRenderer's resolution

@bigtimebuddy bigtimebuddy requested a review from a team November 6, 2022 01:21
@bigtimebuddy bigtimebuddy added this to the v7.1.0 milestone Nov 6, 2022
Copy link
Member

@Julien-Marcou Julien-Marcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Nov 6, 2022
@bigtimebuddy bigtimebuddy merged commit 2e78ba2 into dev Nov 7, 2022
@bigtimebuddy bigtimebuddy deleted the feature/resolution-setter branch November 7, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjusting Scale Breaks Click Events No way to change renderer resolution in 7.0?
2 participants