Fix: Support font assets with space in URL (#8911)

pixijs · Nov 30, 2022 · 06a9562 · 06a9562
1 parent 14a5ce9
commit 06a9562
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/packages/assets/src/loader/parsers/loadWebFont.ts b/packages/assets/src/loader/parsers/loadWebFont.ts
@@ -84,7 +84,7 @@ export const loadWebFont = {
             {
                 const weight = weights[i];
 
-                const font = new FontFace(name, `url(${url})`, {
+                const font = new FontFace(name, `url(${encodeURI(url)})`, {
                     ...data,
                     weight,
                 });

diff --git a/packages/assets/test/assets.tests.ts b/packages/assets/test/assets.tests.ts
@@ -391,4 +391,15 @@ describe('Assets', () =>
 
         expect(font).toBeInstanceOf(FontFace);
     });
+
+    it('should load font assets with space in URL', async () =>
+    {
+        await Assets.init({
+            basePath,
+        });
+
+        const font = await Assets.load('fonts/url with space.ttf');
+
+        expect(font).toBeInstanceOf(FontFace);
+    });
 });
diff --git a/packages/assets/test/assets/fonts/url with space.ttf b/packages/assets/test/assets/fonts/url with space.ttf