Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI instructions when strictNullChecks fails due to Messenger #7748

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Feb 28, 2024

What does this PR do?

Instead of having to ask around, I figured I'd encode these instructions into the CI. Similar to:

See the hidden message below for an example. It's hidden automatically when the issue is resolved.

Checklist

This comment has been minimized.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (bff97ac) to head (37eb9e7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7748   +/-   ##
=======================================
  Coverage   72.15%   72.15%           
=======================================
  Files        1267     1267           
  Lines       39706    39706           
  Branches     7370     7370           
=======================================
  Hits        28650    28650           
  Misses      11056    11056           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fregante
Copy link
Collaborator Author

For a real-life example, see #7734 (comment)

I think it's useful because it immediately leads me to what file needs to be changed.

@fregante fregante requested a review from BLoe February 28, 2024 12:33
Copy link
Collaborator

@grahamlangford grahamlangford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome addition. Thanks!

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fregante fregante merged commit be9c47d into main Feb 28, 2024
19 checks passed
@fregante fregante deleted the F/types/messengerhelp branch February 28, 2024 13:23
@grahamlangford grahamlangford added this to the 1.8.10 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants