Bump typescript from 4.0.5 to 4.3.2 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.5 to 4.3.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.0.5...v4.3.2) Signed-off-by: dependabot[bot] <support@github.com>
fregante
reviewed
Jun 2, 2021
There was a problem hiding this comment.
I had made these changes for TS v4.2 and for some reason now the DB types have some never types that should be string.
Investigating, but I don鈥檛 think that's right.
Edit: v4.3.2 is affected but v4.2 is not. This feels like a regression as every piece still seems to make sense. Maybe we just update to v4.2 for now and try a later version later?
|
@fregante Agree it makes sense to bump to 4.2 for now. Do a quick check and see if you can track down the GitHub issue where the behavior might have changed (probably related to the 4.3 minor version release?) 4.3 release notes: https://devblogs.microsoft.com/typescript/announcing-typescript-4-3/ |
fregante
reviewed
Jun 3, 2021
fregante
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397
Bumps typescript from 4.0.5 to 4.3.2.
Release notes
Sourced from typescript's releases.
... (truncated)
Commits
28e3e6f馃 Pick PR #44219 (Properly remove generic types that ...) into release-4.3 (#...d6e6fa7Cherry-pick PR #44129 into release-4.3 (#44240)27d6e44Bump version to 4.3.2 and LKGfed2315Cherry-pick PR #44186 into release-4.3 (#44188)dec8261Revert #43460 and #40884 (#44175) (#44177)22c3c24Cherry-pick PR #44125 into release-4.3 (#44136)1d850c0Cherry-pick PR #44008 into release-4.3 (#44029)d805ce8Bump version to 4.3.1-rc and LKGbab601bMerge remote-tracking branch 'origin/master' into release-4.35b1e873Update diagnostic message and quickfix for parameter property (#44010)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)