Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency pug to v3.0.1 [security] #118

Merged
merged 1 commit into from May 23, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pug (source) 3.0.0 -> 3.0.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2021-21353

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to pug@3.0.1 or pug-code-gen@3.0.2 or pug-code-gen@2.0.3, which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: pugjs/pug#3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy


Release Notes

pugjs/pug

v3.0.1

Compare Source

Bug Fixes

  • Sanitise the pretty option (#​3314)

    If a malicious attacker could control the pretty option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see #​3312 for more details.


Configuration

📅 Schedule: "" in timezone Europe/Paris.

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 3, 2021

Branch automerge failure

This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.


  • Branch has one or more failed status checks

@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 2 times, most recently from a1c4a6c to 9820ad7 Compare March 17, 2021 21:13
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch from 9820ad7 to 50c617a Compare March 24, 2021 12:31
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 2 times, most recently from 0a64d0f to df5c57e Compare April 11, 2021 14:35
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 4 times, most recently from ce70587 to a8e69f6 Compare April 16, 2021 19:49
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 3 times, most recently from 42e15a8 to 76c3b34 Compare May 21, 2021 20:59
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch 4 times, most recently from b76e3dc to b72407b Compare May 23, 2021 12:43
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch from b72407b to 24f7884 Compare May 23, 2021 12:53
@renovate renovate bot merged commit 52f19c1 into master May 23, 2021
@renovate renovate bot deleted the renovate/npm-pug-vulnerability branch May 23, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant