Skip to content

Commit

Permalink
Upgrade rubocop to 0.68.1 and adds rubocop-performance
Browse files Browse the repository at this point in the history
This should have the same result. The extra gem is because this
rubocop-performance functionality was extracted from the main gem and
needed to be added back in. More info is in rubocop/rubocop#5977
  • Loading branch information
osis committed May 14, 2019
1 parent 99e79c6 commit 44ea01c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
9 changes: 6 additions & 3 deletions ci/scripts/run-rubocop.sh
Expand Up @@ -4,8 +4,11 @@ cd LicenseFinder

bundle install --without runtime default

version=`cat Gemfile.lock | grep ' rubocop' | awk -F'[\(*\)]' '{print $2}'`
gem install rubocop --version $version
rubocop_version=`cat Gemfile.lock | grep ' rubocop' | awk -F'[\(*\)]' '{print $2;exit}'`
rubocop_performance_version=`cat Gemfile.lock | grep ' rubocop-performance' | awk -F'[\(*\)]' '{print $2;exit}'`

gem install rubocop --version $rubocop_version
gem install rubocop-performance --version $rubocop_performance_version

echo "Running Rubocop ..."
/usr/local/bundle/bin/rubocop
/usr/local/bundle/bin/rubocop --require rubocop-performance
3 changes: 2 additions & 1 deletion license_finder.gemspec
Expand Up @@ -59,7 +59,8 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rake'
s.add_development_dependency 'rspec', '~> 3'
s.add_development_dependency 'rspec-its'
s.add_development_dependency 'rubocop', '~> 0.67.2'
s.add_development_dependency 'rubocop', '~> 0.68.1'
s.add_development_dependency 'rubocop-performance', '~> 1.0.0'
s.add_development_dependency 'webmock', '~> 3.5'

# to preserve ruby < 2.2.2 support.
Expand Down

0 comments on commit 44ea01c

Please sign in to comment.