Removed fuzzytm dependency. Fixes #3423.

[ERijck]

Fixes #3423. Supersedes #3424.

[piskvorky]

Thanks @ERijck . You're becoming a git pro :-)

Can you also answer #3424 (comment) please – what's the deal with the dependencies now? For example where does pyfume come from? Is it clearly documented (in a tutorial / import error message / module docstring) how to obtain that dependency? Is there a specific version of pyfume needed?

(there might be other dependencies; I only noticed pyfume in my cursory look)

[piskvorky]

No need for the blank line.

[ERijck]

Haha, thanks for your help and patience @piskvorky! I have replied to your comment in the original thread.

[osma]

Forgive my ignorance, but wouldn't it be easiest to just add pyfume as a dependency in setup.py? Or is there a reason why you want to make it an optional extra?

[piskvorky]

We definitely don't want an additional core dependency, just because of one new module. pyfume is not quite there at the level of numpy, in terms of its footprint on the Gensim architecture.

[piskvorky]

@ERijck can you finish this up?

The current (latest) version of released Gensim is not good, I'd like to release the bugfix ASAP. Thanks!

[ERijck]

@piskvorky do you mean with 'this' that I add an ImportError if pyfume is not installed and then show to install it?

[piskvorky]

No, I meant my review of this PR (above).

But the import stuff we discussed in #3424 (comment) is also relevant.

[ERijck]

In your review you mention dependencies. By adding an ImportError, I thought I covered that issue. Do you agree?
Also, I will remove the blank line.

[piskvorky]

What do you mean by "by adding an ImportError"? I don't see that in this PR.

[ERijck]

In this PR you mention adding an 'import error message'. That is what I meant.

[piskvorky]

Right – but I do not see it added in this PR.

To be clear, what I mean is: what happens when someone imports this module without having its necessary dependencies (pyfume, maybe others)? Do they get a meaningful, actionable error message?

If it's just a question of pyfume, and pyfume is on standard PyPI, it should be trivial: FlsaModel requires pyfume version ????, but pyfume could not be imported. Please install pyfume (e.g. with ``pip install pyfume==?????``) and try again.

But if the dependency/dependencies are not on PyPI, the instructions could be more involved.