Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lint and build for multiple docker files #45

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Conversation

joao10lima
Copy link
Contributor

@joao10lima joao10lima commented Sep 27, 2021

To improve the docker stack uses the git ls-files command, to exclude the git ignore and then loop through the project docker files using the lint and build command in each file.

Resolves: #41

To test:

  • Run the unit tests
  • Test on a project with multiples Dockerfiles
    • Test if the pipeline triggers with changes in any Dockerfile
    • Test if the lint and build stage runs for all Dockerfiles inside the project

Example runs:
https://github.com/pipelinit/pipelinit-sample-docker/runs/3724322039?check_suite_focus=true
https://github.com/pipelinit/pipelinit-sample-docker/runs/3724293013?check_suite_focus=true

To improve the docker stack uses the git ls-files command, to
exclude the git ignore and take all project docker files
under a list and loop through them, then
uses the lint and build command in each of the files

Resolves: #41
@joao10lima joao10lima merged commit 8e0736e into main Sep 30, 2021
@joao10lima joao10lima deleted the fix/dockerfiles branch September 30, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complement the Docker stack
2 participants