Remove checking the resource key with the annotation because their generation logic are different #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neration logic are different Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4891 +/- ##
=======================================
Coverage 29.24% 29.25%
=======================================
Files 318 318
Lines 40597 40593 -4
=======================================
Hits 11874 11874
+ Misses 27784 27780 -4
Partials 939 939 ☔ View full report in Codecov by Sentry. |
|
I checked the prune behavior like below. cluster scoped resource
namespace scoped resource
|
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka and
t-kikuc
as code owners
|
There is a problem about the resource key of cluster scoped resources. I'll consider it later to modify the effect scope. |
t-kikuc
reviewed
Apr 24, 2024
| @@ -147,21 +146,17 @@ func (a *applier) Delete(ctx context.Context, k ResourceKey) (err error) { | |||
| return a.initErr | |||
| } | |||
|
|
|||
| m, err := a.kubectl.Get( | |||
| // Check the resource exists or not using the resource key. | |||
There was a problem hiding this comment.
Suggested change
| // Check the resource exists or not using the resource key. | |
| // Check whether the resource exists or not using the resource key. |
|
close this PR because I decided another solution for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
context: #4269 (comment)
Removed checking the resource key with the annotation because their generation logic differs.
Previously, I tried to keep using the annotation
pipecd.dev/resource-key, but found that some k8s resources inherit the parent's annotation and can't be attached correct resource key.ref: #4858 (comment)
So I decided to remove the checking.
Which issue(s) this PR fixes:
Part of #4269
Previous PR #4858
Does this PR introduce a user-facing change?: