Run golangci-lint on examples #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2566
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2605
💛 - Coveralls |
Sean-Der
force-pushed
the
issue-531
branch
3 times, most recently
from
fd61b90
to
edd0ced
Compare
backkem
approved these changes
Mar 21, 2019
Sean-Der
force-pushed
the
issue-531
branch
2 times, most recently
from
96fc212
to
4fcfe38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
golangci-lint doesn't lint the examples directory golangci/golangci-lint#416
Upstream hasn't responded yet, but for now I am just going to run golangci-lint twice so we can fix the immediate issue
Reference issue
Resolves #531 and Resolves #470