Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Go 1.19 as minimum version #2729

Merged
merged 1 commit into from Apr 4, 2024
Merged

Conversation

hansgylling
Copy link
Contributor

Description

Declare Go 1.19 as minimum version since that's the lowest Go version that can actually build the example programs and run the tests.

Reference issue

Fixes #2728

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (eb6e395) to head (500f5e8).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2729      +/-   ##
==========================================
- Coverage   76.32%   76.29%   -0.04%     
==========================================
  Files          87       87              
  Lines        9846     9846              
==========================================
- Hits         7515     7512       -3     
- Misses       1866     1868       +2     
- Partials      465      466       +1     
Flag Coverage Δ
go 77.82% <ø> (-0.04%) ⬇️
wasm 64.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansgylling
Copy link
Contributor Author

There seems to be 3 more errors from golangci-lint in the lint workflow in this PR compared to the PR before. This is caused by the Go version increase since package io/ioutil was deprecated in Go 1.19. See line 115-118 in the output from golangci-lint. Should I change those 3 uses of io/ioutil in this PR?

Note how the Metadata job in the lint workflow now succeeds compared to before.

Previous job: https://github.com/pion/webrtc/actions/runs/8543153832/job/23406318178

Now: https://github.com/pion/webrtc/actions/runs/8545312740/job/23413312806?pr=2729

@Sean-Der Sean-Der merged commit c1e5386 into pion:v3 Apr 4, 2024
11 of 12 checks passed
@Sean-Der
Copy link
Member

Sean-Der commented Apr 4, 2024

Thank you so much @hansgylling!

Not having to manage configs for every repo is nice, but it is frustrating that as older code bitrots you have this drift :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants