Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleBuilder: Deprecate PopWithTimestamp #2686

Merged
merged 1 commit into from Mar 14, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Feb 29, 2024

SampleBuilder.PopWithTimestamp() will be removed in v4. Use Sample.PacketTimestamp field instead.

Reference issue

SampleBuilder.PopWithTimestamp() will be removed in v4.
Use Sample.PacketTimestamp field instead.
@at-wat at-wat self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3@2828381). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #2686   +/-   ##
=====================================
  Coverage      ?   76.45%           
=====================================
  Files         ?       87           
  Lines         ?     9840           
  Branches      ?        0           
=====================================
  Hits          ?     7523           
  Misses        ?     1856           
  Partials      ?      461           
Flag Coverage Δ
go 78.00% <ø> (?)
wasm 64.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat at-wat merged commit 39919d7 into v3 Mar 14, 2024
12 of 13 checks passed
@at-wat at-wat deleted the samplebuilder/v3/deprecate-PopWithTimestamp branch March 14, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants