Close peerconnection ice gatherer on close #2658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2658 +/- ##
=====================================
Coverage ? 78.56%
=====================================
Files ? 76
Lines ? 8860
Branches ? 0
=====================================
Hits ? 6961
Misses ? 1485
Partials ? 414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SimonVerkada
force-pushed
the
simon/pc-ice-gatherer
branch
from
4b40608
to
372c0a2
Compare
SimonVerkada
commented
Feb 2, 2024
Comment on lines
+2087
to
+2089
| if pc.iceGatherer != nil { | ||
| closeErrs = append(closeErrs, pc.iceGatherer.Close()) | ||
| } |
There was a problem hiding this comment.
The iceTransport closes it's own gatherer, but the peerconnection also maintains it's own separate iceGatherer. Should close this one too.
|
Thanks @SimonVerkada (and great to see you again!) What are the symptoms of the issue? Does this cause a memory/thread leak? Are you able to reproduce it at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes peerconnection's ice gatherer (ice Agent) on close.
Reference issue
Fixes #...