Make setMid of Transceiver public #2074
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
==========================================
- Coverage 76.79% 76.71% -0.09%
==========================================
Files 85 85
Lines 8711 8711
==========================================
- Hits 6690 6683 -7
- Misses 1612 1617 +5
- Partials 409 411 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rtptransceiver.go
Outdated
| @@ -1,3 +1,4 @@ | |||
| //go:build !js | |||
There was a problem hiding this comment.
Is this due to Go version? Does this affect older supported version?
There was a problem hiding this comment.
looks added by IDE, removed.
pionbot
force-pushed
the
setmid
branch
2 times, most recently
from
6d67679
to
bb219c8
Compare
in some case like session migration from one sfu node to another, we need manual set mid of transceiver instead of auto generate, to make mid consistent between to sfu node.
|
nice change :) What do you think of moving this to @cnderrauber That is really exciting that you are moving between SFU nodes! Are you also transferring ICE/SRTP/DTLS/SCTP state? |
|
Thanks @Sean-Der . That Sounds good. I will check this I’m not transfer these state because it is complex. Just use ICE restart to moving to new node. Difficult things is DTLS, because pion will not restart dtls with different fingerprint(but chrome and webrtc does), so I manipulated fingerprint during negotiate with new sfu node. Restart DTLS in pion when fingerprint changed during icerestart is useful and consistent with rfc, I will look at this when have time |
|
That would be awesome, I think we just need to land #1846 ! I wasn't able to find the time to give it the quality of review it needs. But if you and @boks1971 are interested that could be a huge improvement. We just have to be really careful to keep up code quality/not introduce any security bugs :) that was the part that scared me. |
|
Excited! Agree that security is more important than feature, we should be careful about this |
in some case like session migration from one sfu node
to another, we need manual set mid of transceiver instead of
auto generate, to make mid consistent between to sfu node.
Description
Reference issue
Fixes #...