Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go vet fails #531

Closed
kixelated opened this issue Mar 20, 2019 · 1 comment · Fixed by #533
Closed

go vet fails #531

kixelated opened this issue Mar 20, 2019 · 1 comment · Fixed by #533
Assignees

Comments

@kixelated
Copy link
Contributor

Broken by #527

# github.com/pions/webrtc/examples/data-channels
examples/data-channels/main.go:38:3: Printf format %s arg d.Label is a func value, not called
examples/data-channels/main.go:42:4: Printf format %s arg d.Label is a func value, not called
examples/data-channels/main.go:58:4: Printf format %s arg d.Label is a func value, not called
# github.com/pions/webrtc/examples/data-channels-close
examples/data-channels-close/main.go:42:3: Printf format %s arg d.Label is a func value, not called
examples/data-channels-close/main.go:46:4: Printf format %s arg d.Label is a func value, not called
examples/data-channels-close/main.go:51:5: Printf format %s arg d.Label is a func value, not called
examples/data-channels-close/main.go:68:6: Printf format %s arg d.Label is a func value, not called
examples/data-channels-close/main.go:80:4: Printf format %s arg d.Label is a func value, not called
# github.com/pions/webrtc/examples/data-channels-create
examples/data-channels-create/main.go:44:3: Printf format %s arg dataChannel.Label is a func value, not called
examples/data-channels-create/main.go:60:3: Printf format %s arg dataChannel.Label is a func value, not called
# github.com/pions/webrtc/examples/data-channels-detach
examples/data-channels-detach/main.go:52:3: Printf format %s arg d.Label is a func value, not called
examples/data-channels-detach/main.go:56:4: Printf format %s arg d.Label is a func value, not called
# github.com/pions/webrtc/examples/data-channels-detach-create
examples/data-channels-detach-create/main.go:58:3: Printf format %s arg dataChannel.Label is a func value, not called
# github.com/pions/webrtc/examples/ortc
examples/ortc/main.go:49:3: Printf format %s arg channel.Label is a func value, not called
examples/ortc/main.go:54:4: Printf format %s arg channel.Label is a func value, not called
examples/ortc/main.go:134:4: Printf format %s arg channel.Label is a func value, not called
examples/ortc/main.go:153:3: Printf format %s arg channel.Label is a func value, not called
# github.com/pions/webrtc/examples/pion-to-pion/answer
examples/pion-to-pion/answer/main.go:44:3: Printf format %s arg d.Label is a func value, not called
examples/pion-to-pion/answer/main.go:48:4: Printf format %s arg d.Label is a func value, not called
examples/pion-to-pion/answer/main.go:64:4: Printf format %s arg d.Label is a func value, not called
# github.com/pions/webrtc/examples/pion-to-pion/offer
examples/pion-to-pion/offer/main.go:51:3: Printf format %s arg dataChannel.Label is a func value, not called
examples/pion-to-pion/offer/main.go:67:3: Printf format %s arg dataChannel.Label is a func value, not called
@Sean-Der
Copy link
Member

Blocked by golangci/golangci-lint#416 :(

I will fix this and update CI to run golangci-lint twice.

Sean-Der added a commit that referenced this issue Mar 20, 2019
Resolves #531 and Resolves #470
@Sean-Der Sean-Der self-assigned this Mar 20, 2019
Sean-Der added a commit that referenced this issue Mar 20, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 20, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 20, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 21, 2019
Sean-Der added a commit that referenced this issue Mar 21, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 21, 2019
Sean-Der added a commit that referenced this issue Mar 21, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 21, 2019
Sean-Der added a commit that referenced this issue Mar 21, 2019
Sean-Der added a commit that referenced this issue Mar 21, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 21, 2019
Sean-Der added a commit that referenced this issue Mar 21, 2019
Resolves #531 and Resolves #470
Sean-Der added a commit that referenced this issue Mar 21, 2019
@Sean-Der Sean-Der removed the review label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants