Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set read deadline to handle abandoned allocation requests #247

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidzhao
Copy link
Member

Fixes #246

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #247 (8a9e6c8) into master (dfe04cb) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   67.79%   67.93%   +0.13%     
==========================================
  Files          38       38              
  Lines        2400     2401       +1     
==========================================
+ Hits         1627     1631       +4     
+ Misses        641      639       -2     
+ Partials      132      131       -1     
Flag Coverage Δ
go 67.93% <100.00%> (+0.13%) ⬆️
wasm 39.22% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/allocation/allocation.go 85.46% <100.00%> (+0.08%) ⬆️
client.go 71.76% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe04cb...8a9e6c8. Read the comment docs.

Giving it 30s deadline for allocation requests.
@davidzhao
Copy link
Member Author

might have to jumped the gun here, marking as draft while I test a bit more.

@stv0g
Copy link
Member

stv0g commented Jan 23, 2023

@davidzhao Hi David, do you have updates on your testing? I think I've encountered the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allocation requests stuck after being canceled.
2 participants