Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wanted RTP payload type #406

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-allan
Copy link

Description

This PR updates the track implementation to use payload type ID requested by the client.

Without this fix when you run the webrtc example with a non Chromium browser, the client requests a payload type ID such as 126 and we reply with a different type ID, such as 125. When this happens the stream connects but there's no output. Any payload type ID in the range 96-127 is dynamic so we have to negotiate it.

This does fix my issue buy I''m not really sure if this is the best way to fix this. Do we need to support non dynamic payload types too? Do we need to validate bounds or anything?

Reference issue

Fixes this issue I accidentally opened on pion/webrtc repo: pion/webrtc#2237

@EmrysMyrddin
Copy link
Contributor

Hey ! Thank you for your proposal ! Extending compatibility by handling dynamic type ID would be great :-)

But i think we should find a way to do it transparently and automatically. And it would be awesome to avoid breaking the public API by doing it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants