Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BindingRequestHandler #695

Merged
merged 1 commit into from May 2, 2024
Merged

Add BindingRequestHandler #695

merged 1 commit into from May 2, 2024

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented May 1, 2024

Allow the user to perform custom processing for inbound STUN Binding requests. This allows users to do some of the following

  • Log incoming Binding Requests for debugging
  • Implement draft-thatcher-ice-renomination
  • Implement custom CandidatePair switching logic

Resolves pion/webrtc#2539
Resolves pion/webrtc#2585
Resolves #623

@Sean-Der Sean-Der force-pushed the issue-623 branch 3 times, most recently from 6b2e210 to d81f293 Compare May 1, 2024 20:44
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.19%. Comparing base (b5f4ca0) to head (74830a2).

Files Patch % Lines
selection.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   79.13%   79.19%   +0.05%     
==========================================
  Files          41       41              
  Lines        3734     3739       +5     
==========================================
+ Hits         2955     2961       +6     
+ Misses        549      547       -2     
- Partials      230      231       +1     
Flag Coverage Δ
go 79.19% <77.77%> (+0.05%) ⬆️
wasm 22.13% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Allow the user to perform custom processing for inbound STUN Binding
requests. This allows users to do some of the following

* Log incoming Binding Requests for debugging
* Implement draft-thatcher-ice-renomination
* Implement custom CandidatePair switching logic

Resolves pion/webrtc#2539
Resolves pion/webrtc#2585
Resolves #623
@Sean-Der Sean-Der merged commit 07b74c8 into master May 2, 2024
15 checks passed
@Sean-Der Sean-Der deleted the issue-623 branch May 2, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant