Add support for session resumption when using client certificates #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to need some tests. |
eh-steve
force-pushed
the
session-store-support-cert-verification-expiry
branch
2 times, most recently
from
2bbb298
to
2561eb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 75.81% 75.87% +0.05%
==========================================
Files 96 96
Lines 5586 5599 +13
==========================================
+ Hits 4235 4248 +13
Misses 1019 1019
Partials 332 332
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I can’t really tell from the logs whether the CI is failing due to my changes… if it’s just the commit message linting, I was going to squash everything |
|
Yeah, it's just the commit message. All the other checks passed. |
Allow mutual authentication (RequireAndVerifyClientCert/ VerifyClientCertIfGiven)to work with session resumption by recording the certificate expiry time in the session struct
eh-steve
force-pushed
the
session-store-support-cert-verification-expiry
branch
from
2561eb0
to
61c44b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if a client submitted a certificate, any session resumption would be ignored in order to mitigate indefinite extension attacks as per https://curl.se/docs/CVE-2016-5419.html, but this prevented improving performance under mutual authentication use cases.
Now if
RequireAndVerifyClientCert/VerifyClientCertIfGivenare used, the certificate expiry time is recorded in the session struct, allowing the user provided session store to decide what to do with "expired" sessions.Revocations are still not handled via this mechanism, and the old behaviour can be preserved using the new config
PeerCertDisablesSessionResumption