Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return useful error for incorrect channel type #201

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

Sean-Der
Copy link
Member

Before (Wrapped for linter)

invalid Message Type &{%!s(datachannel.ChannelType=0)
%!s(uint16=256) %!s(uint32=0) initial_data_channel }

Now (Wrapped for linter)

expected and actual message type does not match, wanted ACK
got Open ChannelType(PartialReliableRexmitUnordered) Priority(500)
ReliabilityParameter(750) Label(Sean) Protocol(Test)

Resolves #125
Resolves pion/webrtc#2258

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 65.84%. Comparing base (f56395b) to head (f55406a).

❗ Current head f55406a differs from pull request most recent head c45cc49. Consider uploading reports for the commit c45cc49 to get more accurate results

Files Patch % Lines
message_channel_open.go 0.00% 16 Missing ⚠️
message_channel_ack.go 0.00% 2 Missing ⚠️
datachannel.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   69.70%   65.84%   -3.87%     
==========================================
  Files           4        4              
  Lines         307      325      +18     
==========================================
  Hits          214      214              
- Misses         68       86      +18     
  Partials       25       25              
Flag Coverage Δ
go 65.84% <0.00%> (-3.87%) ⬇️
wasm 65.84% <0.00%> (-3.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Before (Wrapped for linter)
```
invalid Message Type &{%!s(datachannel.ChannelType=0)
%!s(uint16=256) %!s(uint32=0) initial_data_channel }
```

Now (Wrapped for linter)
```
expected and actual message type does not match, wanted ACK
got Open ChannelType(PartialReliableRexmitUnordered) Priority(500)
ReliabilityParameter(750) Label(Sean) Protocol(Test)
```

Resolves #125
Resolves pion/webrtc#2258
@Sean-Der Sean-Der merged commit 9449b50 into master Mar 28, 2024
13 checks passed
@Sean-Der Sean-Der deleted the issue-125 branch March 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to handle DCEP: invalid Message Type Invalid formatting for "Failed to handle DCEP" error
1 participant