Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Client always commit params #196

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Make Client always commit params #196

merged 1 commit into from
Mar 6, 2024

Conversation

edaniels
Copy link
Member

Description

Without this, there's a race (see test change) where we can send messages with the wrong reliability guarantees after Client returns and before it processes its DCEP ACK message. This can easily happen if a DataChannel is created via a Dial and Accept flow where there's no OnOpen and the starts writing immediately.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.70%. Comparing base (02dc2ec) to head (998a790).

Files Patch % Lines
datachannel.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   68.83%   69.70%   +0.87%     
==========================================
  Files           4        4              
  Lines         308      307       -1     
==========================================
+ Hits          212      214       +2     
+ Misses         70       68       -2     
+ Partials       26       25       -1     
Flag Coverage Δ
go 69.70% <66.66%> (+0.87%) ⬆️
wasm 69.70% <66.66%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels
Copy link
Member Author

edaniels commented Mar 6, 2024

@Sean-Der merging. This should be harmless and the test properly fails when I undo the fix.

@edaniels edaniels merged commit f784cc1 into master Mar 6, 2024
13 of 14 checks passed
@edaniels edaniels deleted the commit_params_client branch March 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant