Try to enable Gradle Daemon again #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
changed the title
|
Merge this after #1884. |
This reverts commit a50e0bd.
# Conflicts: # .github/workflows/gradle-pr-build.yml
Goooler
commented
Mar 25, 2023
build.gradle.kts
Outdated
Comment on lines
24
to
29
| retry { | ||
| if (System.getenv().containsKey("CI")) { | ||
| maxRetries.set(3) | ||
| maxFailures.set(20) | ||
| } | ||
| } |
There was a problem hiding this comment.
We can enable this retry if flaky tests occur again, just remove it for now.
|
I am really to go enjoy the improved speed of the build. Tnx! |
|
My pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gradle Daemon was disabled for PR Build jobs in #1584 as some there were flaky tests on Windows, re-enable it for now.
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule: