Remove logback specific configuration from ktlint-core package #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
Mar 20, 2022
ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/KtLintKLoggerInitializer.kt
Outdated
Show resolved
Hide resolved
Goooler
reviewed
Mar 20, 2022
…lic constant which were part of the public API to inform API users about its removal. Closes pinterest#1421
ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/KtLintKLoggerInitializer.kt
Show resolved
Hide resolved
ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/KtLintKLoggerInitializer.kt
Outdated
Show resolved
Hide resolved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed logback dependency from
ktlint-coremodule to fix #1421loggingModifierfunction, which allows to perform arbitrary logic with logger object and executes after logger initialization.logback-test.xmlfile inktlint-test-loggingmodule to use in unit tests. Logging level configured providing environment propertyKTLINT_UNIT_TEST_TRACEwith valueON(case insensitive)Usage of
ktlint-corepackage by external tools was successfully checked by updating ktlint version in maven pluginChecklist
CHANGELOG.mdis updatedIn case of adding a new rule:
README.mdis updated