Allow to set a default logger modifier #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
z3d1k
reviewed
Mar 20, 2022
Comment on lines
+15
to
+19
| * Default modifier for the KLogger of new instances of classes calling [initKtLintKLogger]. Classes for which | ||
| * [initKtLintKLogger] has been called before setting this variable will not be changed. Also note, that this modifier | ||
| * can only be set once. | ||
| */ | ||
| public lateinit var defaultLoggerModifier: (KLogger) -> Unit |
There was a problem hiding this comment.
Also note, that this modifier can only be set once.
Are there any checks to support that statement? lateinit only checks whether the variable has been initialized before it is accessed, no additional checks on its modification are performed.
There was a problem hiding this comment.
Tnx again. That was a rookie mistake. I have improved it in #1430. I can not prevent the variable from being set more than once as it will break some integration tests in ktlint. I have now succeeded to print a warning (to discourage doing it) whenever it happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule:
README.mdis updated